search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Use Git SCM as provider for stash pull request builder #21

Closed laurentverbruggen closed 9 years ago

laurentverbruggen commented 9 years ago

Use Git SCM as provider for hostname and credentials needed for the pull request builder.

Now it is also possible to verify pull requests from another fork (while previously it would only work in the same repository, or at least with the merge before build feature). Prerequisite is that you add +refs/pull-requests/:refs/remotes/origin/pr/ as refspec.

Additionally you can filter on the target branch which makes you able to restrict checking pull requests on a specific (release) branch.

And last but not least, support for global environment variables has been added.

laurentverbruggen commented 9 years ago

I just noticed that I forgot to update the README. I'll do that later, but you already look at this in the meantime.

nemccarthy commented 9 years ago

LGTM, thanks for this @laurentverbruggen !!!

nemccarthy commented 9 years ago

I've pushed this as v1.3 should be in jenkins in the next few hrs.

nemccarthy commented 9 years ago

Looks like this PR has created a few issues.

Namely if using an SSH stash host the hostname is an invalid URI.

nemccarthy commented 7 years ago

This also added the race condition, going to need to revert this one