search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Comments trigger a new build #23

Closed emmaguy closed 9 years ago

emmaguy commented 9 years ago

Hey,

This plugin works great for us, but with one exception - when someone raises a pull request and there are comments left, the plugin seems to detect this as a change and does another build. This then causes quite a lot of noise/emails when really we only want it to build when it's raised and then again if there's another push.

Am I missing something with the configuration?

nemccarthy commented 9 years ago

@emmaguy doesn't sound like the right behaviour. If there is a comment "test this please" then it will rebuild the PR. Are your comments in order? Does it happen with all pul requests? Which version of Stash & the plugin are you using?

Try setting the phrase to something random. Could you post some screenshots of the comments and your plugin configuration

emmaguy commented 9 years ago

Jenkins v1.613, Plugin is v1.2.0. I haven't changed the phrase to rebuild the PR, perhaps it's because it's empty? Yeah, this happens on all PRs

screen shot 2015-06-25 at 9 31 50 am

I'll try setting the phrase. Any other thoughts would be appreciated. Thanks!

emmaguy commented 9 years ago

Having a non empty phrase seems to be better :smile: :+1: Thanks!