search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Approve pull request #24

Closed jesavro closed 8 years ago

jesavro commented 9 years ago

Can this module approve pull requests as well?

Thank you Avi

laurentverbruggen commented 9 years ago

No it can't, but why would you want to automate approvals? It seems simply disabling a required number of approvals does the same thing...

jesavro commented 9 years ago

We have various stages of approvals. I would like to have automated tests provide the first approval.

nemccarthy commented 8 years ago

If you are using the stash notifier plugin you can set the number of required builds to be >= 1. This has the same effect. As soon as the PR build is done, stash will be notified for that commit and you will have 1 successful build. If you set the number of builds as a PR gate it seems to make more sense and achieve the same effect. See the instructions on the integration between this plugin and the stash notifier plugin. If you want to do an approval, it still would be possible, happy to take a PR on this one, however closing this issue for now