search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Allow suppressing commenting on pull requests #54

Closed akhaku closed 8 years ago

akhaku commented 8 years ago

Fixes #53. Adds a config to disable the "Build started" and "Build Success"/"Build Failed" comments, along with the removal of the "Build started" comment.

Note that I haven't been able to test this - would appreciate a smoke test. I don't have jenkins set up - could do so if necessary.

nemccarthy commented 8 years ago

Thanks for this PR, but I think we will use #52 which handles storage of the build state. Does this do what you were after?

You can't just turn off the comments as they are used for state management. If they are off you need to manage and persist the state elsewhere so you don't get PR builds being re-run through Jenkins restarts.

akhaku commented 8 years ago

Ah sorry, missed that PR. Yeah, I don't handle the state management, didn't realize that was necessary. Closing in favor of #52.