search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Use Credentials to store Stash login username and password #61

Closed nickbroon closed 8 years ago

nickbroon commented 8 years ago

Just as the title says :-) StashBuildTrigger class now keeps a Jenkins Credentials Object instead of Username and Password, with this exposed in the config.jelly GUI using the appropriate Jelly expected Getters and doFillCredentialsIdItems methods. Tested, and works fine in my setup, with credentials listed, and the configured one remembered.

nickbroon commented 8 years ago

@nemccarthy should I submit this PR against https://github.com/jenkinsci/stash-pullrequest-builder-plugin?

nemccarthy commented 8 years ago

Awesome! Thanks for this @nickbroon. Its ok here, I'll review ASAP

byF commented 8 years ago

Is this planned for 1.4.3?

nickbroon commented 8 years ago

As it's not backwards compatible it will have to be at least a 1.5 release. (It ignores/removes the previous username/password stored directly in the plugin config. The user needs to create a new entry in the credentials store)

benheymink commented 8 years ago

Any update on the merge @nemccarthy? Been watching this one :)