search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Post Build Tasks blocking concurrent builds #73

Open jeremybarr opened 8 years ago

jeremybarr commented 8 years ago

If I am running basically a PR build/merge job on multiple nodes, the post build tasks wait on any previous jobs running before they will finish. In the case of PR builds, there is not always the need to wait on previous builds when running concurrently on multiple nodes since they may be from different PRs. Would it be possible to add an option to not have the post build tasks wait on checkpoints?

nemccarthy commented 8 years ago

Not sure if this is possible. Worth looking into if someone wants to take this up

erdnussflips commented 6 years ago

@nemccarthy: You need to change the return value of getRequiredMonitorService() in StashPostBuildComment from BuildStepMonitor.BUILD to BuildStepMonitor.NONE. See http://javadoc.jenkins-ci.org/hudson/tasks/BuildStep.html#getRequiredMonitorService--

So your code must look like this public BuildStepMonitor getRequiredMonitorService() { return BuildStepMonitor.NONE; }

jakub-bochenski commented 6 years ago

What @ErdnussFlipS wrote is correct. This problem has been affecting many plugins you can check the fix for sloccount with links to other fixes here: https://github.com/jenkinsci/sloccount-plugin/commit/d205dc8a50f4f488657fac2ee293235fc31d1712