search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Include default parameter values in build queue #74

Closed superdave closed 8 years ago

superdave commented 8 years ago

Default parameter values were not being included in queued builds, resulting in problems with build scripts which expected those values to exist. The getDefaultValues() method was already defined, but unused; now, it is called and its results added to the parameter Map.

Kaned1as commented 8 years ago

Better to put them prior to filling map. This way we can override some defaults by comment parameters.

superdave commented 8 years ago

Good point, I'll make that change soon.