search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Customize CI Build Phrases #8

Closed soasme closed 9 years ago

soasme commented 9 years ago

I think test this please is too verbose to type (and is easy to make typo). Allowing customize ciBuildPhrases is much more flexible, just like ciSkipPhrases.

PS. I have no idea how to test jenkins plugin, so this pr is still not tested :(

soasme commented 9 years ago

@nemccarthy code review please

soasme commented 9 years ago

It's being tested and just works :)

configure

screenshot

nightwolfzor commented 9 years ago

This is a good change but would it make more sense as a global config setting? And maybe move skip there too?

nemccarthy commented 9 years ago

+1 for some global config but there also seems a need for this to be configured per project. Thanks for the PR!