nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

"only build on comment" mode does not work after the first comment. #86

Closed PierreBtz closed 8 years ago

PierreBtz commented 8 years ago

Detailed test case:

This comes from the parsing of comments which should stop at the first buildStarted/buildFinished message it encounters in onlyBuildOnComment mode. Instead, the parsing will continue and finally find the initial trigger comment.

I have a fix ready, I'll be happy to make a PR if you confirm this behavior is not expected.

PierreBtz commented 8 years ago

Hello @nemccarthy,

Do you have any input on the previous comment? I can confirm that my fix has been working successfully on my production CI for more than a month now.