search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Changes to how variables are added to the build #89

Closed eirikwang closed 8 years ago

eirikwang commented 8 years ago

Jenkins issue SECURITY-180 added a new security feature that only lets declared variables into the build. This fix rewrites the plugin to use environment contributor which is the proper way to give properties to a build.

This closes #84

nickbroon commented 8 years ago

:+1:

nickbroon commented 8 years ago

@nemccarthy, can this be merged? As mentioned in #84 this is critical fix to be able to update Jenkins past 2.2

Macarse commented 8 years ago

what's blocking this PR?

dreis2211 commented 8 years ago

+1

tiberiuzuld commented 8 years ago

+1

PixnBits commented 8 years ago

Having access to ${sourceCommitHash} is the last step for PR build notifications for my team, project member reviews of this PR are very appreciated by us (and particularly me, as I'm the reporting robot for now :P)

PixnBits commented 7 years ago

(belated) thanks, @nemccarthy :)