td 1911 0289: schematisation checker skips culvert fields invert_level_start_point en invert_level_end_point

nens / threedi-modelchecker

Tool to verify the correctness of a 3Di model

MIT License

0 stars 2 forks source link

Closed Jonasvsl closed 5 years ago

Jonasvsl commented 5 years ago

Describe your issue:

Tot mijn grote verbazing wordt er in de schematisatiechecker niet gecheckt of de invert_level_start_point en invert_level_end_point zijn ingevuld in v2_culvert. Deze zijn verplicht, anders komt het model niet door inpy heen. Graag nog toevoegen!

Jonas: Volgens mij zouden we dit moeten checken toch? Daarom als bug geklassicifeerd

RichardB9 commented 5 years ago

Cannot reproduce this bug. Setting a random Pipe.invert_level_end_point to null and running the schematisation-checker finds and shows the error.

Jonasvsl commented 5 years ago

ok, I have requested more information via topdesk

Jonasvsl commented 5 years ago

@RichardB9 this models gives no errors in the schematisation checker but has empty invert_level_start_point and end_points

I checked to be sure:

RichardB9 commented 5 years ago

Ah, I oversaw that we were talking about culverts specifically. Culverts.invert_level_start_point and Culvert.invert_level_end_point are currently configured to accept null values see: https://github.com/nens/threedi-modelchecker/blob/master/threedi_modelchecker/threedi_model/models.py#L591

So I can add these two columns to the not-null check?

Jonasvsl commented 5 years ago

that is correct.