nens / threedi-schematisation-editor

QGIS tool for editing schematisations
0 stars 0 forks source link

"Import culverts" GUI #119

Closed leendertvanwolfswinkel closed 11 months ago

leendertvanwolfswinkel commented 1 year ago

The dialog should look like this: image.png

The dialog has two tabs, one for culverts and one for connection nodes. Culverts that are added in a location where the start or end vertex is within snapping distance (specified by the user) of a connection node will be connected to that connection node. If no connection node is present within snapping distance, connection node(s) will be created. For those newly created connection nodes, the properties can be set in the 'connection nodes' tab.

The columns in the table in the image are in bold in the explanation below.

For each attribute in the target layer, the user can choose which method to use to fill it: the value can be (a) left empty, i.e. NULL (b) taken from the source attribute, or (c) use a default. If the user wants the values to be taken from the source layer, there are two additional considerations:

Further details for each culvert attribute specifically, see this Excel sheet: https://nelenschuurmans-my.sharepoint.com/:x:/g/personal/leendert_vanwolfswinkel_nelen-schuurmans_nl/ETjOz94ZsbJOsKk18jfZZNMBWUkhxw3oVDim7wc9MlDydw?e=T7WWXP

Other requirements/considerations:

leendertvanwolfswinkel commented 1 year ago

@ldebek Really nice work, I am super happy about this!

Some additional wishes after testing:

leendertvanwolfswinkel commented 12 months ago

@ldebek Tested it and everything seems to work great.

Can you just make this one minor improvement:

Please include the target table in the error message. In the example below, it took me some time to figure out that these missing fields refer to the connection nodes

Please specify a source field for a following attribute(s) and try again:
Connection node: Code
Connection node: Initial water level [m]
Connection node: Storage area [m²]
ldebek commented 11 months ago

@leendertvanwolfswinkel Layer name added to the message.