nens / threedi-schematisation-editor

QGIS tool for editing schematisations
0 stars 0 forks source link

Processing algorithm Generate Exchange lines improvements #131

Closed leendertvanwolfswinkel closed 1 year ago

leendertvanwolfswinkel commented 1 year ago
leendertvanwolfswinkel commented 1 year ago

Please also make sure the new Processing Algorithms group uses the same icon as the '3Di' group. Currently, the icon is smaller:

image.png

ldebek commented 1 year ago

@leendertvanwolfswinkel PR with requested changes: https://github.com/nens/threedi-schematisation-editor/pull/132

leendertvanwolfswinkel commented 1 year ago

All the issues in this ticket are fixed, but...

Now the whole algorithm doesn't work anymore, because I get this error:

Could not commit changes to layer Exchange line

Errors: ERROR: 1 feature(s) not added.

  Provider errors:
      OGR error creating feature -7021: failed to prepare SQL: INSERT INTO "exchange_line" ( "geom", "id", "channel_id", "exchange_level") VALUES (?, ?, ?, ?) - undersize RTree blobs in "rtree_exchange_line_geom_node"

I also committed some changes to the user feedback messages, please have a look at those changes.

ldebek commented 1 year ago

@leendertvanwolfswinkel Could you please send me info about QGIS build you are using with libs listed? It doesn't look like a problem with an algorithm itself, but with writing data to the Geopackage file. Isn't some other process accessing while you are trying to use algorithm? Btw. I'm not experiencing such issue on my QGIS 3.28.