search

neo-project / neo-modules

MIT License
60 stars 100 forks source link

fix rpc error #894

Closed Jim8y closed 8 months ago

Jim8y commented 8 months ago

This pr fix the rpc error

Jim8y commented 8 months ago

@cschuchardt88

Jim8y commented 8 months ago

I was sure that we've fixed all of them in #815.

This was newly introduced in a merged pr, but i have no idea why it can pass the workflow.

@AnnaShaleva please review again

vncoelho commented 8 months ago

testing here again

cschuchardt88 commented 8 months ago

testing here again

Its sample simple change; shouldn't affect anything but RpcServer Method error output

vncoelho commented 8 months ago

Application log is fixed.

Oracle still not

#42 24.21 /opt/neo-modules/src/OracleService/OracleService.cs(260,65): error CS1503: Argument 3: cannot convert from 'byte[]' to 'Neo.Cryptography.ECC.ECCurve' [/opt/neo-modules/src/OracleService/OracleService.csproj]
cschuchardt88 commented 8 months ago

Application log is fixed.

Oracle still not

#42 24.21 /opt/neo-modules/src/OracleService/OracleService.cs(260,65): error CS1503: Argument 3: cannot convert from 'byte[]' to 'Neo.Cryptography.ECC.ECCurve' [/opt/neo-modules/src/OracleService/OracleService.csproj]

net8.0 upgrade PR will fix it...

cschuchardt88 commented 8 months ago

@shargon currently main.yml doesn't do a dotnet build on all projects on this repo... Which is way is was missed.

shargon commented 8 months ago

@shargon currently main.yml doesn't do a dotnet build on all projects on this repo... Which is way is was missed.

I don't know, time ago neo-modules was not maintained by core devs...