search

neo09 / gwt-platform

Automatically exported from code.google.com/p/gwt-platform
0 stars 0 forks source link

Action and Result should implement IsSerializable interface instead of Serializable #68

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is a copy of http://code.google.com/p/gwt-dispatch/issues/detail?id=7

Currently, Action and Result interfaces extend Serializable interface. 
However Google recomends to use IsSerializable: 
http://code.google.com/intl/en/webtoolkit/doc/1.6/FAQ_Server.html#Does_the_G
WT_RPC_system_support_the_use_of_java.io.Serializable

I'd like to remove the need to use @SuppressWarnings("serial").

David (of gwt-dispatch) closed the bug with wont-fix because he wanted to 
keep the core classes non-GWT-dependent, however GWTP is pretty GWT 
dependent.

Original issue reported on code.google.com by brendanp...@gmail.com on 28 Apr 2010 at 3:10

GoogleCodeExporter commented 9 years ago 
The doc you refer to in GWT is outdated. Do you see the same recommendation in 
GWT 2.0?

What about adding serialVersionUID to your class instead of suppressing the 
warning? 
Having a serialVersionUID makes serialized classes more robust to changes.

Original comment by philippe.beaudoin on 28 Apr 2010 at 3:20

GoogleCodeExporter commented 9 years ago 
Same info.

http://code.google.com/intl/en/webtoolkit/doc/latest/FAQ_Server.html#Does_the_GW
T_RPC_s
ystem_support_the_use_of_java.io.Serializable

Original comment by brendanp...@gmail.com on 28 Apr 2010 at 3:25

GoogleCodeExporter commented 9 years ago 
After reading this, it makes tons of sense, especially since actions and 
results are 
not really meant to be serialized server-side.

I will make the change.

Original comment by philippe.beaudoin on 28 Apr 2010 at 5:34

GoogleCodeExporter commented 9 years ago

Original comment by philippe.beaudoin on 28 Apr 2010 at 5:40

GoogleCodeExporter commented 9 years ago 
If you want, I can so it while woring on issue 63.

Original comment by goudreau...@gmail.com on 28 Apr 2010 at 11:03

GoogleCodeExporter commented 9 years ago 
Go ahead, I've assigned the issue to you.

Original comment by philippe.beaudoin on 28 Apr 2010 at 3:39

GoogleCodeExporter commented 9 years ago

Original comment by goudreau...@gmail.com on 29 Apr 2010 at 5:41

GoogleCodeExporter commented 9 years ago

Original comment by goudreau...@gmail.com on 3 May 2010 at 9:08

GoogleCodeExporter commented 9 years ago 
Need review for : 
http://code.google.com/r/goudreauchristian-gwtpdispatch/source/detail?
r=7bf5bb13dbcd30e83fb462fb051169f397364717

Original comment by goudreau...@gmail.com on 3 May 2010 at 9:15

GoogleCodeExporter commented 9 years ago 
LGTM feel free to commit.

Original comment by philippe.beaudoin on 3 May 2010 at 9:20

GoogleCodeExporter commented 9 years ago

Original comment by goudreau...@gmail.com on 4 May 2010 at 2:54