search

neo4j-php / neo4j-symfony

Symfony Bundle for the Neo4j Graph Database
MIT License
78 stars 41 forks source link

Change port to scalarNode in Config #53

Closed ikwattro closed 5 years ago

ikwattro commented 5 years ago

Hi @Nyholm ,

Is it advisable to you that we change the config for the port setting from integerNode to scalarNode ?

https://github.com/neo4j-contrib/neo4j-symfony/blob/master/DependencyInjection/Configuration.php#L90

The use case is when the port is passed via the env and sf 3.3 does not support casting of string values.

Nyholm commented 5 years ago

That sounds like a great idea. Thanks

Nyholm commented 5 years ago

This is fixed in #54