search

neocities / neocities-ruby

The Neocities Gem - A CLI and library for using the Neocities web site API.
https://neocities.org
52 stars 14 forks source link

Add a dry run option to 'neocities push'. #28

Closed dmbaturin closed 4 years ago

dmbaturin commented 5 years ago

When messing up with pages (or static site generator setup), it can be easy to forget you made a bigger change than you wanted to push.

With this option one can see what would be uploaded without actually uploading it:

neocities push --dry-run .
dmbaturin commented 4 years ago

I've been using it for a while now and I'm more than sure it's safe to merge.

dmbaturin commented 4 years ago

Is there anything missing to have this merged? Or this is simply a WONTFIX?

kyledrake commented 4 years ago

Apologies for the delay, it's been a crazy month. I'll try to review it tonight

On Fri, Mar 6, 2020, 7:07 PM Daniil Baturin notifications@github.com wrote:

Is there anything missing to have this merged? Or this is simply a WONTFIX?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/neocities/neocities-ruby/pull/28?email_source=notifications&email_token=AAAG36PC2VX62ZOUWYGDQRDRGGF2XA5CNFSM4JOGBF4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEODHSRY#issuecomment-596015431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAG36IPUDGKQQPOCWVK7PTRGGF2XANCNFSM4JOGBF4A .

kyledrake commented 4 years ago

Thanks for this PR, it's great! Apologies again for the delay. I'll get a new version out.