search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.16k stars 168 forks source link

[1.20.6] Wolf armor cannot be sheared off with custom shear #1062

Closed cech12 closed 2 months ago

cech12 commented 3 months ago

I am the mod developer of 2 shears mods WoodenShears and CeramicShears and and I am working on updating my mods to 1.20.6.

In Neoforge 20.6.111-beta there were some changes I waited on and there is only one small issue I found during testing my mod in the new environment: Wolf armor cannot be sheared off. This feature was added in Minecraft 1.20.5: https://minecraft.wiki/w/Java_Edition_1.20.5#Items

I think in the Wolf entity mobInteract method there should be added a check for a tools action. Maybe SHEARS_HARVEST could be reused or a new action should be added for this purpose.

Thanks for your help! :)

RaymondBlaze commented 3 months ago

IShearable feels like a more suitable place to add the support, though moving the interaction from Wolf#mobInteract to IShearable may cause inconsistency with vanilla if not carefully implemented.

cech12 commented 3 months ago

That could also be done with the IShearable interface. It would be great if that could be supported at least in 1.21 :)

Thanks for all your work!