search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
164 stars 21 forks source link

ci: add coverage report #1043

Closed mikhail-sakhnov closed 2 months ago

mikhail-sakhnov commented 3 months ago

Add fgrosse/go-coverage-report@v1.0.2 step to render coverage diff report on PRs

mikhail-sakhnov commented 2 months ago

@Omrigan as we discussed, I added the comment with HTML report link

@bayandin I resolved your notices about adding comment and dropping default value for pull_requests: node.

bayandin commented 2 months ago

I added the comment with HTML report link

Are you talking about this comment https://github.com/neondatabase/autoscaling/pull/1043#issuecomment-2317465793? Should we upload this report to S3 to make it easier to view? And probably having a single comment would be a bit more tidy

mikhail-sakhnov commented 2 months ago

@Omrigan @bayandin I merged the comments into a single comment. Speaking about the S3, I created infra issue to set up the credentials for this repo, but it will be triaged next Monday and not clear how much time will it take for the actual work on the issue. What if we merge with the artifacts based report and once all the aws authorization bits and pieces are in place, change the workflow to use s3 again? Another option is to just leave PR here for a while in the open state

mikhail-sakhnov commented 2 months ago

@Omrigan @bayandin folks, it stores the report in S3 now

github-actions[bot] commented 2 months ago

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ :robot:
github.com/neondatabase/autoscaling/pkg/util 17.86% (+1.59%) :thumbsup:
Coverage by file ### Changed unit test files - github.com/neondatabase/autoscaling/pkg/util/time_test.go

HTML Report

Click to open