neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
164 stars 21 forks source link

neonvm: revert crictl patches #1054

Closed Omrigan closed 1 month ago

Omrigan commented 2 months ago

We decided to go another route, and disable outer cgroup altogether in favor of something better.

Closes https://github.com/neondatabase/cloud/issues/13266.

github-actions[bot] commented 1 month ago

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ :robot:
github.com/neondatabase/autoscaling/neonvm 0.00% (ø)
github.com/neondatabase/autoscaling/neonvm/apis/neonvm/v1 0.56% (ø)
github.com/neondatabase/autoscaling/neonvm/controllers 11.51% (-0.59%) :thumbsdown:
github.com/neondatabase/autoscaling/neonvm/controllers/functests 0.00% (ø)
github.com/neondatabase/autoscaling/neonvm/runner 0.00% (ø)
github.com/neondatabase/autoscaling/neonvm/runner/container-mgr 0.00% (ø)

Coverage by file ### Changed files (no unit tests) | Changed File | Coverage Δ | Total | Covered | Missed | :robot: | |--------------|------------|-------|---------|--------|---------| | github.com/neondatabase/autoscaling/neonvm/apis/neonvm/v1/virtualmachine_webhook.go | 0.00% (ø) | 51 | 0 | 51 | | | github.com/neondatabase/autoscaling/neonvm/controllers/config.go | 0.00% (**-66.67%**) | 0 (-3) | 0 (-2) | 0 (-1) | :skull: :skull: :skull: :skull: :skull: | | github.com/neondatabase/autoscaling/neonvm/controllers/vm_controller.go | 25.23% (**-0.58%**) | 662 (-24) | 167 (-10) | 495 (-14) | :thumbsdown: | | github.com/neondatabase/autoscaling/neonvm/main.go | 0.00% (ø) | 130 (-21) | 0 | 130 (-21) | | | github.com/neondatabase/autoscaling/neonvm/runner/container-mgr/crictl.go | 0.00% (ø) | 0 (-31) | 0 | 0 (-31) | | | github.com/neondatabase/autoscaling/neonvm/runner/container-mgr/main.go | 0.00% (ø) | 0 (-122) | 0 | 0 (-122) | | | github.com/neondatabase/autoscaling/neonvm/runner/main.go | 0.00% (ø) | 787 | 0 | 787 | | _Please note that the "Total", "Covered", and "Missed" counts above refer to ***code statements*** instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code._ ### Changed unit test files - github.com/neondatabase/autoscaling/neonvm/controllers/functests/vm_controller_test.go - github.com/neondatabase/autoscaling/neonvm/controllers/vm_controller_unit_test.go

HTML Report

Click to open