search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
164 stars 21 forks source link

neonvm: Remove `GuestSettings.SwapInfo` #1064

Closed sharnoff closed 2 months ago

sharnoff commented 2 months ago

We'd initially planned to switch to it when we added resizable swap suppport (#887, #912), but this never materialized. We have nothing using it in production, so it's just tech debt :)

Came across this as part of #1063, figured we might as well remove it.

github-actions[bot] commented 2 months ago

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ :robot:
github.com/neondatabase/autoscaling/neonvm/apis/neonvm/v1 0.56% (+0.04%) :thumbsup:
github.com/neondatabase/autoscaling/neonvm/controllers 12.10% (+0.02%) :thumbsup:
github.com/neondatabase/autoscaling/neonvm/runner 0.00% (ø)
Coverage by file ### Changed files (no unit tests) | Changed File | Coverage Δ | Total | Covered | Missed | :robot: | |--------------|------------|-------|---------|--------|---------| | github.com/neondatabase/autoscaling/neonvm/apis/neonvm/v1/virtualmachine_types.go | 1.92% (**+0.26%**) | 52 (-8) | 1 | 51 (-8) | :thumbsup: | | github.com/neondatabase/autoscaling/neonvm/apis/neonvm/v1/virtualmachine_webhook.go | 0.00% (ø) | 51 (-13) | 0 | 51 (-13) | | | github.com/neondatabase/autoscaling/neonvm/apis/neonvm/v1/zz_generated.deepcopy.go | 0.00% (ø) | 423 (-15) | 0 | 423 (-15) | | | github.com/neondatabase/autoscaling/neonvm/controllers/vm_controller.go | 25.80% (**+0.11%**) | 686 (-3) | 177 | 509 (-3) | :thumbsup: | | github.com/neondatabase/autoscaling/neonvm/runner/main.go | 0.00% (ø) | 783 (-3) | 0 | 783 (-3) | | _Please note that the "Total", "Covered", and "Missed" counts above refer to ***code statements*** instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code._

HTML Report

Click to open