neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
164 stars 21 forks source link

neonvm-controller: Patch status even if reconcile fails #1103

Open sharnoff opened 1 month ago

sharnoff commented 1 month ago

Fixes #889. Extracted out from #1009.

Might be worthwhile to require #1102 because otherwise we'll end up double-failing when the VM object is out of date...

github-actions[bot] commented 1 month ago

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ :robot:
github.com/neondatabase/autoscaling/pkg/neonvm/controllers 11.48% (-0.03%) :thumbsdown:

Coverage by file ### Changed files (no unit tests) | Changed File | Coverage Δ | Total | Covered | Missed | :robot: | |--------------|------------|-------|---------|--------|---------| | github.com/neondatabase/autoscaling/pkg/neonvm/controllers/vm_controller.go | 25.08% (**-0.15%**) | 666 (+4) | 167 | 499 (+4) | :thumbsdown: | _Please note that the "Total", "Covered", and "Missed" counts above refer to ***code statements*** instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code._

HTML Report

Click to open