neooffice / NeoOffice

Other
34 stars 5 forks source link

Spelling and Grammar Checkers must be reenabled after NeoOffice is Started (macOS Ventura) #14

Open froses opened 2 years ago

froses commented 2 years ago

Hi,

Spelling and Grammar checkers works fine on macOS Ventura, but I must uncheck & check "Check spelling / grammar as you type" every time I start NeoOffice. If not, NeoOffice don't check spelling nor grammar while I'm typing.

Once rechecked, those options work fine. If I open another document, NeoOfice checks spelling and grammar while I write. But if I close NeoOffice, next time I open it, I need to recheck the spelling and grammar options.

On macOS Monterey, I have the same problem, but only with the Grammar Checker.

In both cases, I use LanguageTool Grammar Checker. I use the latest macOS versions (Ventura 13.0 beta (22A5373b) and Monterey 12.6).

Best regards,

Francesc Rosés Albiol

plubius commented 2 years ago

Unfortunately, I cannot reproduce what you are seeing on my Mac Silicon machine with either macOS Monterey or Ventura. I am using the same macOS versions that you listed so maybe I am doing something different than you?

I have installed LanguageTool version 4.1 from the following website. NeoOffice 2022 is based on LibreOffice 4.4 so LanguageTool version 4.1 appears to be the only version compatible with NeoOffice:

https://extensions.libreoffice.org/en/extensions/show/languagetool

IIRC, you use a Catalan spellchecker so I have attached a small document with the document's language set to Catalan. After restarting NeoOffice, I see the wavy line appear under the misspelled words and the grammar error in the last line within a few seconds after opening the document on both Monterey and Ventura. catalan.odt

froses commented 2 years ago

Hi,

I’m using Intel-based computers (a MacBook Pro 2018 with Ventura Beta and a Mac Mini Late 2014 with Monterey) and LanguageTool 5.8 (without problems) with Oracle Java 1.8.0_251.

macOS Ventura: I opened your sample Catalan file, and today it seems LanguageTool is working, but the spelling checker is not working:  If I go to NeoOffice Preferences, I observe the option to check spell as you type is checked: 

If I uncheck and check the option, the spelling checker will work: 

macOS Monterey: In this case, the spelling checker is working but LanguageTool it isn’t. 

In my Mac Mini, when I check the LanguageTool version, a warning message arises: "It seems the automatic grammar check is disabled. Please enable "Check grammar as you type at Tools/Options/Language Settings/Writing Aids" and restart LibreOffice/OpenOffice”. But ”Check grammar as you type” is checked.

So, if I uncheck and check the option… spelling and grammar checkers are working together. 

Maybe it is a problem with my computers or with Intel-based computers. But is not a big issue (I have a work arround!).

Thank you so much for your work!

Regards,

Francesc Rosés Albiol

El 18 oct. 2022, a les 20:03, PL @.***> va escriure:

Unfortunately, I cannot reproduce what you are seeing on my Mac Silicon machine with either macOS Monterey or Ventura. I am using the same macOS versions that you listed so maybe I am doing something different than you?

I have installed LanguageTool version 4.1 from the following website. NeoOffice 2022 is based on LibreOffice 4.4 so LanguageTool version 4.1 appears to be the only version compatible with NeoOffice:

https://extensions.libreoffice.org/en/extensions/show/languagetool

IIRC, you use a Catalan spellchecker so I have attached a small document with the document's language set to Catalan. After restarting NeoOffice, I see the wavy line appear under the misspelled words and the grammar error in the last line within a few seconds after opening the document on both Monterey and Ventura. catalan.odt https://github.com/neooffice/NeoOffice/files/9813921/catalan.odt — Reply to this email directly, view it on GitHub https://github.com/neooffice/NeoOffice/issues/14#issuecomment-1282802535, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6VTSOUXXCXXOCJZDRQOCDWD3Q7RANCNFSM6AAAAAARHX5I4Y. You are receiving this because you authored the thread.

plubius commented 2 years ago

I am not very familiar with LibreOffice's extension loading code but I tried installing and using LanguageTool 4.1 on macOS Monterey 12.6 on my Mac Intel machine. I can't install macOS Ventura on that machine, but when I use Oracle's JDK 1.8 like you, installation of the extension fails with a Java error.

However, if I select Oracle's newer JDK 17 in NeoOffice's preferences dialog, I can install LanguageTool 4.1 and both spell checking and grammar checking work in my catalan.odt document immediately after restarting NeoOffice.

So, maybe the issue is that LanguageTool is incompatible with older versions of Java. If you want to test LanguageTool with a newer version of Java, you can download Oracle's JDK 17 from the following website:

https://www.oracle.com/java/technologies/downloads/#jdk17-mac

Note: if you install Oracle's JDK 17, you will need to also download and install the following NeoOffice test patch that fixes loading of JDK 17:

https://github.com/neooffice/NeoOffice/releases/download/NeoOffice-2022_3/NeoOffice-2022.3_Professional_Edition-Patch-0-Test-1-Universal.dmg

froses commented 2 years ago

Hi,

I am (I was because I'm retired...) a Java developer, so I have "all" Java versions installed :).

All is a mystery, but I can write without problems... I think the LanguageTool API strategy is better (but you need to be online!).

Interesting the LanguageTool integration with Mail, Messages, and Notes. Have you tested it? (https://languagetool.org/mac-desktop)

Thank you so much for your work!

Regards,

Francesc Rosés Albiol