search

neovim / homebrew-neovim

Homebrew formula
MIT License
402 stars 72 forks source link

Build a release version by default #210

Closed Haegin closed 7 years ago

Haegin commented 7 years ago

If you want the old RelWithDebInfo pass --with-debug-info when installing.

justinmk commented 7 years ago

Why?

Haegin commented 7 years ago

It's meant to speed up airline (and any other plugins that behave similarly), but while it might be slightly faster than the version with debug info it wasn't enough for me to be convinced it's worth it. Does seem that a release version for the stable channel should be enough though.

justinmk commented 7 years ago

but while it might be slightly faster than the version with debug info it wasn't enough for me to be convinced it's worth it.

Can we get some numbers using :profile? In https://github.com/neovim/homebrew-neovim/issues/209 it's implied that Release will fix the issue. If it's not going to fix anything then there's no reason to change anything.

Haegin commented 7 years ago

Having done some more investigation it looks like I was wrong - airline is still slow even with this change.

justinmk commented 7 years ago

Thanks for the follow-up