fix(asyncio): close child_watcher before the main loop is closed

neovim / pynvim

Python client and plugin host for Nvim

http://pynvim.readthedocs.io/en/latest/

Apache License 2.0

1.47k stars 118 forks source link

fix(asyncio): close child_watcher before the main loop is closed #556

Closed wookayin closed 6 months ago

wookayin commented 6 months ago

This might fix #555.

TODO:

Reproduce the bug
Add tests

wookayin commented 6 months ago

/cc @pierreganty can you please test if this PR fixes your issue in #555?

To checkout a PR:

git clone https://github.com/neovim/pynvim
cd pynvim
git fetch origin pull/556/head
git checkout FETCH_HEAD
pip install -e .

and then run neovim (make sure you have a proper python3 host on which this devel version of pynvim is installed).

pierreganty commented 6 months ago

I have tried and made sure it uses pynvim Version: 0.5.1.dev0 (I followed your clear instructions) but the behavior is the same: the output gets flooded with the same messages as described in #555.

wookayin commented 6 months ago

Closing because this does not fix the issue. see #555