search

nephila / djangocms-page-meta

OpenGraph, Twitter Card and Google+ snippet tags for django CMS 3 pages
https://djangocms-page-meta.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
59 stars 64 forks source link

Fix deprecated 'edit_mode' attribute (compatible) #100

Closed jeroenpeters1986 closed 5 years ago

jeroenpeters1986 commented 5 years ago

Fix deprecated 'edit_mode' attribute which was removed as of DjangoCMS 3.6 It's now backwards compatible up to DjangoCMS 3.4

This was reported in issue #99

jeroenpeters1986 commented 5 years ago

@yakky Like the sitemap plugin (see sitemap#30), this plugin also was not compatible with DjangoCMS 3.6 anymore.

jeroenpeters1986 commented 5 years ago

Also, as you can see in the integration tests, support for everything below Django 1.11 is dropped by DjangoCMS 3.6 now

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.5%) to 90.789% when pulling e1cdb370dad2ae6629ede0d42a46c5975a76e53c on jeroenpeters1986:hotfix/issue-99 into 2d12d8716b0cd4198da57269f076fd69a69b50de on nephila:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.5%) to 90.789% when pulling e1cdb370dad2ae6629ede0d42a46c5975a76e53c on jeroenpeters1986:hotfix/issue-99 into 2d12d8716b0cd4198da57269f076fd69a69b50de on nephila:master.

yakky commented 5 years ago

@jeroenpeters1986 thanks for this I'd rather merge #97 which also addresses the new NoReverseMatch, reverse import I plan to do a release with all the django CMS 3.6 related fixes very soon

Thanks for your time and the patience

jeroenpeters1986 commented 5 years ago

@jeroenpeters1986 thanks for this I'd rather merge #97 which also addresses the new NoReverseMatch, reverse import I plan to do a release with all the django CMS 3.6 related fixes very soon

Thanks for your time and the patience

Not a problem ofcourse! You should take the best / most complete PR. Thanks for letting me know

yakky commented 5 years ago

@jeroenpeters1986 thanks for your time to propose this :bowing_man: I'll keep this open until the support will be merged (in any PR)

yakky commented 5 years ago

@jeroenpeters1986 closed with #100 thanks for your work!

jeroenpeters1986 commented 5 years ago

No problem, thanks again for your work!