nephila / djangocms-page-meta

OpenGraph, Twitter Card and Google+ snippet tags for django CMS 3 pages
https://djangocms-page-meta.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
60 stars 64 forks source link

fix: update version of dep. "filer" 1.2 → 3.0 #175

Closed wesleyboar closed 1 year ago

wesleyboar commented 1 year ago

Description

References

Fix #173

Checklist

tox output summary ``` black: OK (0.42=setup[0.02]+cmd[0.39] seconds) blacken: OK (0.13=setup[0.00]+cmd[0.12] seconds) docs: OK (1.21=setup[0.01]+cmd[1.20] seconds) isort: OK (0.12=setup[0.00]+cmd[0.12] seconds) isort_format: OK (0.13=setup[0.00]+cmd[0.12] seconds) ruff: OK (0.14=setup[0.00]+cmd[0.04,0.10] seconds) pypi-description: OK (21.03=setup[0.01]+cmd[0.28,13.29,7.26,0.20] seconds) towncrier: OK (0.11=setup[0.00]+cmd[0.11] seconds) py311-django42-cms311: OK (5.35=setup[1.85]+cmd[3.50] seconds) py311-django41-cms311: OK (5.21=setup[1.71]+cmd[3.50] seconds) py310-django42-cms311: SKIP (0.25 seconds) py310-django41-cms311: SKIP (0.00 seconds) py39-django42-cms311: OK (8.43=setup[2.46]+cmd[5.97] seconds) py39-django41-cms311: OK (27.03=setup[21.14]+cmd[5.90] seconds) py311-django32-cms311: OK (19.84=setup[15.53]+cmd[4.32] seconds) py311-django32-cms39: OK (19.93=setup[15.46]+cmd[4.48] seconds) py310-django32-cms311: SKIP (0.00 seconds) py310-django32-cms39: SKIP (0.00 seconds) py39-django32-cms311: OK (25.12=setup[18.82]+cmd[6.30] seconds) py39-django32-cms39: OK (25.23=setup[17.32]+cmd[7.91] seconds) congratulations :) (159.73 seconds) ```

[^1]: I did pip install -r requirements-test.txt and pip install -e ., but when I ran inv lint, the output was zsh: command not found: inv. Consider expanding on this instruction… for noobs like me. [^2]: Seemed irrelevant to the change.

protoroto commented 1 year ago

@wesleyboar Thank you very much for this pr! I'll hope to merge this as soon as possible and release 1.4.1

coveralls commented 1 year ago

Coverage Status

coverage: 94.621%. remained the same when pulling afaf1500514b7bc7341265407755c7f7d22f6171 on wesleyboar:bugfix/173-filer-update into f95f0596dfddbdb9d6768bc9a90d8a26b9d69fdc on nephila:develop.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (f95f059) 91.19% compared to head (afaf150) 91.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #175 +/- ## ======================================== Coverage 91.19% 91.19% ======================================== Files 9 9 Lines 409 409 Branches 61 61 ======================================== Hits 373 373 Misses 22 22 Partials 14 14 ``` | [Flag](https://app.codecov.io/gh/nephila/djangocms-page-meta/pull/175/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nephila/djangocms-page-meta/pull/175/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | `91.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.