Django 2.0 and Django 2.1 compatibility

[kuvandjiev]

• added compatibility with Django 2.0 and Django 2.1
• added compatibility with DjangoCMS 3.6
• removed Python 2.7 compatibility
• on_delete added to the foreign key fields
• correctly importing reverse and NoReverseMatch
• using Django JavaScriptCatalog instead of javascript_catalog in the test

[yakky]

Thanks @kuvandjiev for your contribution I don't think we can drop python 2 just yet I would like to make a 0.8.x release with all the django CMS 3.6 related fixes and I think we sould be able to support Django 2.0 / 2.1 without dropping python 2 then we can put python 2 to rest

what do you think?

[kuvandjiev]

Thank you for looking into this. I can amend the PR and leave the python 2 compatibility intact. Unrelated, I had difficulties running the tests, could you please help a little with the configuration.

[yakky]

@kuvandjiev thanks for your quick feedback. Probably it's better to wait for #101 to land, which will provide a more solid base for tests :)

Check also the changes against #97 which already provides some of the compatibility code than in this MR Maybe we can let land #97 first (which will provide the compatible imports ) and keep the other django 2.x compatibily code here (just trying to minise the combined effort for everyone)

[codecov[bot]]

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6a7937b). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff             @@
##             develop      #98   +/-   ##
==========================================
  Coverage           ?   87.01%           
==========================================
  Files              ?        8           
  Lines              ?      362           
  Branches           ?       44           
==========================================
  Hits               ?      315           
  Misses             ?       35           
  Partials           ?       12

Impacted Files	Coverage Δ
djangocms_page_meta/admin.py	95.34% <ø> (ø)
djangocms_page_meta/settings.py	60% <ø> (ø)
djangocms_page_meta/utils.py	83.48% <ø> (ø)
djangocms_page_meta/forms.py	89.47% <ø> (ø)
djangocms_page_meta/templatetags/page_meta_tags.py	100% <ø> (ø)
djangocms_page_meta/apps.py	100% <ø> (ø)
djangocms_page_meta/cms_toolbars.py	90% <100%> (ø)
djangocms_page_meta/models.py	84.53% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a7937b...6e6ad61. Read the comment docs.

[codecov[bot]]

Codecov Report

Merging #98 into feature/django-2.0 will not change coverage. The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           feature/django-2.0      #98   +/-   ##
===================================================
  Coverage               87.98%   87.98%           
===================================================
  Files                       8        8           
  Lines                     383      383           
  Branches                   48       48           
===================================================
  Hits                      337      337           
  Misses                     33       33           
  Partials                   13       13

Impacted Files	Coverage Δ
djangocms_page_meta/admin.py	95.45% <ø> (ø)	:arrow_up:
djangocms_page_meta/models.py	85.14% <100%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10d6cff...4c29b39. Read the comment docs.

[coveralls]

Coverage remained the same at 91.473% when pulling 4c29b39825c60b16b14e04f5e4ab0ed358f28d62 on kuvandjiev:django_2_1_compatibility into 10d6cffcc90b67baba9f98ea332ba3ac71a84fc7 on nephila:feature/django-2.0.

[yakky]

Thanks @kuvandjiev !