search

nephila / djangocms-page-meta

OpenGraph, Twitter Card and Google+ snippet tags for django CMS 3 pages
https://djangocms-page-meta.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
59 stars 64 forks source link

'CMSToolbar' object has no attribute 'edit_mode' #99

Closed marcosguedes closed 5 years ago

marcosguedes commented 5 years ago

Hi everyone at Nephila. It's me again :D

This package is also breaking on Django CMS 3.6 due to the error above.

I can try to make a PR later today if at all possible.

Thanks!

Marcos

marcosguedes commented 5 years ago

Stacktrace

File "/home/marcos/.virtualenvs/myproject/lib/python3.6/site-packages/djangocms_page_meta/cms_toolbars.py" in populate
  49.             not_edit_mode = not self.toolbar.edit_mode

Exception Type: AttributeError at /
Exception Value: 'CMSToolbar' object has no attribute 'edit_mode'
atiberghien commented 5 years ago

Exactly same for me : Django==1.11.20 django-cms==3.6.0 django-meta==1.4.1 djangocms-page-meta==0.8.3

yakky commented 5 years ago

@marcosguedes :bowing_man: We'll take care of 3.6 on all our applications in the next days, thanks for your patience!

marcosguedes commented 5 years ago

No worries, greatly appreciated. @jeroenpeters1986 is the real hero, not me :)

Thank you for your hard work!

yakky commented 5 years ago

everyone taking time to contribute by opening an issue or adding a comment is a hero! not joking

yakky commented 5 years ago

closed with #100 thanks for your work!

jeroenpeters1986 commented 5 years ago

everyone taking time to contribute by opening an issue or adding a comment is a hero! not joking

Agreed! Thanks for merging

selmanceker commented 5 years ago

On Divio cloud the current version is 0.8.3. Can anyone also upgrade it there? Thanks :)

yakky commented 5 years ago

@selmanceker updated. IDK why it did not went through. Be aware that there is still an issue with django 2.0+ which will be fixed in 0.8.5 due in a few hours

yakky commented 5 years ago

@selmanceker 0.8.5 released with migration fix

selmanceker commented 5 years ago

Thank you @yakky for informing me and for this awesome package :).

yakky commented 5 years ago

thanks for your kind words! :bowing_man: