nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
104 stars 53 forks source link

PackageReivsion deletionProposed sometimes deletes the packageRevision. #798

Closed nagygergo closed 3 weeks ago

nagygergo commented 1 month ago

Sometimes when packages are marked for deletionProposed state, they get deleted. This happens about 80% of the time to 'main' packageRevisions, to versioned packages, it happens a bit less.

NAME                                                            PACKAGE         WORKSPACENAME   REVISION   LATEST   LIFECYCLE   REPOSITORY
app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77    my-blueprint      v1              main       false    Published   app-blueprints-repo
app-blueprints-repo-86604d989ccb8f80f4519fbf51293cfcb8fb8f3f    my-blueprint      v1              v1         true     Published   app-blueprints-repo
app-deployments-repo-5fff0d0cd82be22f474671394d9634aec9f7a025   my-sample-app   v1              main       false    Published   app-deployments-repo
app-deployments-repo-d38b16ec1cf2fcf26a5787d53ab683162e2b2c39   my-sample-app   v1              v1         true     Published   app-deployments-repo

Deleting all created package revisions...
+ porchctl -n porch-test rpkg propose-delete app-deployments-repo-d38b16ec1cf2fcf26a5787d53ab683162e2b2c39
app-deployments-repo-d38b16ec1cf2fcf26a5787d53ab683162e2b2c39 proposed for deletion
+ porchctl -n porch-test rpkg delete app-deployments-repo-d38b16ec1cf2fcf26a5787d53ab683162e2b2c39
app-deployments-repo-d38b16ec1cf2fcf26a5787d53ab683162e2b2c39 deleted

++ porchctl -n porch-test rpkg get --name my-sample-app
++ awk '$1=="NAME"{getline; print $1}'
+ DEPLOYMENT_PKG_UNIQ_NAME_2=app-deployments-repo-5fff0d0cd82be22f474671394d9634aec9f7a025
+ porchctl -n porch-test rpkg propose-delete app-deployments-repo-5fff0d0cd82be22f474671394d9634aec9f7a025
app-deployments-repo-5fff0d0cd82be22f474671394d9634aec9f7a025 proposed for deletion
+ porchctl -n porch-test rpkg delete app-deployments-repo-5fff0d0cd82be22f474671394d9634aec9f7a025
app-deployments-repo-5fff0d0cd82be22f474671394d9634aec9f7a025 deleted

+ porchctl -n porch-test rpkg propose-delete app-blueprints-repo-86604d989ccb8f80f4519fbf51293cfcb8fb8f3f
app-blueprints-repo-86604d989ccb8f80f4519fbf51293cfcb8fb8f3f proposed for deletion
+ porchctl -n porch-test rpkg delete app-blueprints-repo-86604d989ccb8f80f4519fbf51293cfcb8fb8f3f
app-blueprints-repo-86604d989ccb8f80f4519fbf51293cfcb8fb8f3f deleted

++ porchctl -n porch-test rpkg get --name my-blueprint
++ awk '$1=="NAME"{getline; print $1}'
+ BLUEPRINT_PKG_UNIQ_NAME_2=app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77
+ porchctl -n porch-test rpkg propose-delete app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77
app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77 proposed for deletion
+ porchctl -n porch-test rpkg delete app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77
app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77 failed (packagerevisions.porch.kpt.dev "app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77" not found)
Error: errors:
  packagerevisions.porch.kpt.dev "app-blueprints-repo-5dccb5283bb8161f20e9875ee2e346931fb15e77" not found 
kushnaidu commented 3 weeks ago

PR created - https://github.com/nephio-project/porch/pull/99 Waiting for reviews