search

nervosnetwork / ckb-cli

CKB command line interface
MIT License
59 stars 36 forks source link

When no git information was found, the sub-command `--version` outputs a pair of empty brackets. #609

Closed yangby-cryptape closed 2 months ago

yangby-cryptape commented 4 months ago

Issue

When no git information was found (e.g., no .git directory), the sub-command --version outputs a pair of empty brackets.

I think the pair of empty brackets should be ignored, when no content between them.

Current Behavior

Input:

./ckb-cli --version

Output:

ckb-cli 1.9.0 ( )

Expected Behavior

Output:

ckb-cli 1.9.0
github-actions[bot] commented 3 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

eval-exec commented 2 months ago

has been fixed by https://github.com/nervosnetwork/ckb-cli/pull/613