chore(deps): support express 5 as peer dependency - Githubissues

nestjs / serve-static

Serve static websites (SPA's) using Nest framework (node.js) 🥦

https://nestjs.com/

MIT License

465 stars 60 forks source link

chore(deps): support express 5 as peer dependency #1522

Open orgads opened 1 week ago

orgads commented 1 week ago

PR Checklist

Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

express peer dependency is limited to v4, while v5 is already released.

What is the new behavior?

Support also v5.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

kamilmysliwiec commented 1 day ago

Blocked until this https://github.com/nestjs/nest/pull/14238#issuecomment-2505794634 is merged