search

netbirdio / netbird

Connect your devices into a secure WireGuard®-based overlay network with SSO, MFA and granular access controls.
https://netbird.io
BSD 3-Clause "New" or "Revised" License
11.32k stars 519 forks source link

"Add Rule" button opens "Add Route" dialog if no rules are present #1561

Closed b00nish closed 9 months ago

b00nish commented 9 months ago

Describe the problem

If there is a total of 0 rules existing, the button "Add Rule" will open the "Add Route" dialog instead of the "Add Rule" dialog. Therefore you can't create any more rules.

To Reproduce

Steps to reproduce the behavior:

  1. Go to "Access Control" in the web interface
  2. Delete all rules
  3. Click on "New Rule"
  4. See the "New Route" dialog appear instead of the "New Rule" dialog

Expected behavior

It is expected and necessary that the "New Rule" button brings up the "New Rule" dialog because otherwise one is stuck with no rules and therefore an unuseable Netbird instance.

Are you using NetBird Cloud?

Self-Hosted

NetBird version

I assume 0.25.6 because I installed today

surik commented 9 months ago

Fix: https://github.com/netbirdio/dashboard/pull/326

surik commented 9 months ago

This should be fixed. Please feel free to reopen it if you are still experiencing the same.

b00nish commented 9 months ago

Thanks for your super fast reaction. I'm not very familiar with the whole Docker process.

Can I simply upgrade as described in your documentation here in order to receive the fix?

surik commented 9 months ago

@b00nish yes, this should be enough.