search

netbymatt / ws4kp

WeatherStar 4000+
https://weatherstar.netbymatt.com
MIT License
263 stars 44 forks source link

Add Docker build #23

Closed rmitchellscott closed 1 year ago

rmitchellscott commented 1 year ago

This PR adds a Dockerfile to build and run the project, a GitHub Action to build the Docker image, and push to this repo's GitHub Container Registry.

Additionally, I've added a Docker example in the readme.

netbymatt commented 1 year ago

I like this idea a lot. I understand the idea of Docker but have never used it myself other than one time through their quick start demo guide. I'm doing a little reading on it and may have a question or two before I merge.

For now, I think we can remove the pinning to Node 16 per newer findings in #24.

rmitchellscott commented 1 year ago

Agreed, just pushed a commit to pin to Node 18. We could pin to node:lts-alpine, but I usually like to pin to specific majors, then bump that when a new LTS is released.