search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 3 forks source link

Filter first pass at remove tab for VFOI #248

Closed jdanish closed 1 year ago

jdanish commented 1 year ago

Currently the filtering functionality has an option to highlight (fade) or filter, which hides the items not selected, but doesn't change their impact on the system. It'd be nice to have an additional "remove" tab that removes the impact of the filtered items on the system (e.g., don't impact centrality). Note that this should only be on the local display copy, so it will not impact the stored data.

benloh commented 1 year ago

Working on this will be a good way to get our heads around the filtering system and current data/state management. So prioritizing it in front of the others.

jdanish commented 1 year ago

I wonder if we should change the top-level label to "Views" or something like that so that filter, highlight, remove and then eventually highlight or decorate or whatever all fit? Not a high priority but related.

benloh commented 1 year ago

@jdanish how should the filtering search work for "remove/collapse"? Are we removing everything that matches? Or are we keeping everything that matches?

e.g. if I set a Collapse filter for nodes: , should we remove all the "Person" nodes, or should we remove all the non-person nodes?

jdanish commented 1 year ago

I think keep is most intuitive and matches the others.

benloh commented 1 year ago

Addressed. Close for now. See pull request #264