search

netherfoam / Titan

Emulates a RuneScape 637 Server using a slightly modified protocol
3 stars 1 forks source link

refactor(warp): clean up warp command #63

Closed netherfoam closed 7 years ago

titan-sonar commented 8 years ago

SonarQube analysis reported 24 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Warp.java#L26: The Cyclomatic Complexity of this method "execute" is 11 which is greater than 10 authorized. rule
  2. MAJOR Core.java#L43: Remove this unused "LOGGER" private field. rule
  3. MAJOR Core.java#L137: Remove usage of generic wildcard type. rule
  4. MINOR Warp.java#L17: Document this public class. rule
  5. MINOR Warp.java#L20: Document this public constructor. rule
  6. MINOR Warp.java#L49: Use a StringBuilder instead. rule
  7. MINOR Warp.java#L49: At most one statement is allowed per line, but 2 statements were found on this line. rule
  8. MINOR Warp.java#L97: Document this public class. rule
  9. MINOR Warp.java#L111: Document this public class. rule
  10. MINOR Warp.java#L112: Document this public constructor. rule