netlabel / netlabel_tools

Tools to manage the Linux NetLabel subsystem
GNU General Public License v2.0
27 stars 8 forks source link

Improve cut on IPv6 addresses #11

Closed hubertqc closed 2 years ago

hubertqc commented 2 years ago

Make cut retrieve the complete IPv6 address

pcmoore commented 2 years ago

Hi @hubertqc, thanks for submitting a PR to fix this! A couple of things with respect to the patch description and subject line:

Sometimes it can be helpful to look at previous commits which are now in-tree as a source of examples; the top of the current main branch, commit https://github.com/netlabel/netlabel_tools/commit/b9776c02c65d5d7bd2353c095e3d7f8702ab18f2, is a decent example.

Hopefully this helps, but if you have any questions don't hesitate to ask.

Thanks!

hubertqc commented 2 years ago

Hi @pcmoore ,

Thank you very much for your guidance and your patience.

I've just amended the commit message to comply with your recommendations regarding both signing the commit and formatting the commit label.

Thanks.

pcmoore commented 2 years ago

Hi @hubertqc, I apologize that it took me a week to get back to this, but the revision looks great to me, thanks for sticking with this. I've gone ahead and merged the commit via 4636ae9c62d5dd2666b16326d95ee22671909460, thanks!