search

netlify / explorers

https://explorers.netlify.com/
MIT License
261 stars 40 forks source link

[broken thing] customer unable to see explorers profile #518

Open wein-hillary opened 2 years ago

wein-hillary commented 2 years ago

What needs fixed? This customer is unable to see their Jamstack Explorers profile. They have included a series of screenshots of what they see and when they see it.

They say "these errors happen under explorers.netlify.com/profile. I’m using Windos10 (original), conecting from Spain. I tried accessing the profile with and without the “cache” enabled in Chrome’s DevTools > Network, but the bug shows anyway. I was not in incognito mode. I tried accessing with Firefox 92.0 (64bit) and Chrome 63.0.x (64.bit)."

Communication from Support surrounding issue:

  1. https://netlify.slack.com/archives/CCC1HDWQY/p1631638526104700
  2. https://netlify.slack.com/archives/C016VMDSEJG/p1634929577001000
wein-hillary commented 2 years ago

(Not sure what mscw:must is, tag auto added. I will leave it until a member of DevEx determines if it is necessary.)

zachleat commented 2 years ago

I can reproduce this

image

maybe related to https://github.com/vercel/next.js/discussions/16850 ?

zachleat commented 2 years ago

Got this running the project locally:

image

zachleat commented 2 years ago

Looks like this was introduced by https://github.com/netlify/explorers/commit/859c848ad3f732a4e173ef2284ca57828e5f5af1#diff-c919a6612353db575a3e855e9f751a5b27414e6ba55a75c8c614582ee973514f

based on this preliminary research I think @bencodezen or @tzmanics might be the best person to look at this

https://github.com/netlify/explorers/blame/main/src/components/UserMissionInfo.js#L19

zachleat commented 2 years ago

I would note that changing {mission.instructors[0]} to {mission.instructor} fixes the issue on this page specifically but I don’t think this is in spirit with the changes made in the original PR for the feature at #515

tzmanics commented 2 years ago

looking into in now, thanks for digging into it @wein-hillary & @zachleat !

wein-hillary commented 2 years ago

Thank you so so much, @tzmanics and @zachleat!

bencodezen commented 2 years ago

So the proper fix would be to figure out why only one instructor is being passed down into the Author, but given that the entire page is broken, reverting it to single author is the best solution to iterate on. Let me know if y'all have any questions in the meantime!