netlify / framework-info

Framework detection utility
MIT License
137 stars 21 forks source link

fix: fixed typo in qwik excluded dependency #805

Closed nickytonline closed 2 years ago

nickytonline commented 2 years ago

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

There was a typo in the excluded npm dependencies for the vite framework information, causing multiple frameworks to be returned fort Qwik. The typo has been fixed.

Now instead of

❯ ntl dev
Debugger attached.
β—ˆ Netlify Dev β—ˆ
β—ˆ Ignored general context env var: LANG (defined in process)
? Multiple possible start commands found (Use arrow keys or type to search)
❯ [Qwik] 'npm run build.client' 
  [Qwik] 'npm run build.ssr' 
  [Qwik] 'npm run dev.client' 
  [Qwik] 'npm run dev.debug' 
  [Qwik] 'npm run dev.ssr' 
  [Vite] 'npm run build.client' 
  [Vite] 'npm run build.ssr' 
(Move up and down to reveal more choices)

when you run ntl dev, you'll get the following because only one framework is found.

β—ˆ Starting Netlify Dev with Qwik

> build.client
> vite build

I think there's another issue when it runs ntl dev because it runs the first dev command it finds, e.g. build.client, but this is a completely separate issue that needs to be investigate.

Fixes #804


For us to review and ship your PR efficiently, please perform the following steps:

A picture of a cute animal (not mandatory, but encouraged)