search

netlify / open-api

Open API specification of Netlify's API
https://open-api.netlify.com/#/default
MIT License
263 stars 84 forks source link

Fix Incorrect Return Response for go version 1.21.1 #499

Closed MilanVaghasiya26 closed 1 year ago

MilanVaghasiya26 commented 1 year ago

When using Go version 1.21.1, there is an issue with the response handling inside the ReadResponse function in the create_dns_record_responses.go file. The current implementation does not correctly handle responses in certain scenarios, leading to incorrect results or unexpected behavior.

Proposed Solution:

I propose to investigate and fix the issue with the response handling in the ReadResponse function to ensure it works correctly with Go version 1.21.1.

image

anand-panigrahi commented 1 year ago

@minivan

MilanVaghasiya26 commented 1 year ago

@lemonScaletech I already tried but make generate will erase the code changes

anand-panigrahi commented 1 year ago

ohhhhhhh is it so ? I have also seen this problem. Can you ping me once if this get done.

mraerino commented 1 year ago

can you help me understanding your problem? can you provide an example project that fails with 1.21.1? or a PR detailing the changes you tried to explain in your screenshot?

MilanVaghasiya26 commented 1 year ago

First of all thanks for commenting.

I am a newbie and going through netlify, I have figured out the mistake. It was my bad. But you should include a example. If you want I can created a PR for example. :) cheers.