Closed Skn0tt closed 9 months ago
Comparing with 9e82c5a761d0a00fe92cb8221f7e48756f46d06e
β¬οΈ 0.43% decrease vs. 9e82c5a761d0a00fe92cb8221f7e48756f46d06e
^ 1.5s 1.5s 1.5s 1.5s 1.5s
β 1.4s ββββ ββββ 1.4s ββββ 1.4s ββββ 1.4s 1.4s ββββ 1.4s 1.5s 1.5s
β βββββββββββΌβββΌβββββΌβββΌβββββββββββββΌβββΌβββββββββββββΌβββΌβββββββββββββββββββββΌβββΌββββββββββββββββββββββββββ
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄ββ>
T-12 T-11 T-10 T-9 T-8 T-7 T-6 T-5 T-4 T-3 T-2 T-1 T
β¬οΈ 2.58% increase vs. 9e82c5a761d0a00fe92cb8221f7e48756f46d06e
^ 5.8s 5.8s 5.7s 5.7s 5.8s
β 5.5s ββββ ββββ 5.6s 5.6s 5.5s ββββ 5.5s ββββ 5.4s 5.6s ββββ
β βββββββββββΌβββΌβββββΌβββΌββββββββββββ5.3sβββββββββββββββββββββΌβββΌβββββββββββββΌβββΌββββββββββββββββββββ|ββ|ββ
β | | | | | | | | ββββ | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄ββ>
T-12 T-11 T-10 T-9 T-8 T-7 T-6 T-5 T-4 T-3 T-2 T-1 T
β¬οΈ 1.06% increase vs. 9e82c5a761d0a00fe92cb8221f7e48756f46d06e
^ 10.7s 10.9s 10.7s
β 10.1s ββββ 10.6s 10.5s 10.5s 10.3s 10.4s 10.6s 10.4s ββββ 10.2s 10.6s ββββ
β βββββββββββΌβββΌβββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββΌβββΌββββββββββββββββββββ|ββ|ββ
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
β | | | | | | | | | | | | | | | | | | | | | | | | |ββ|
βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄βββββ΄βββ΄ββ>
T-12 T-11 T-10 T-9 T-8 T-7 T-6 T-5 T-4 T-3 T-2 T-1 T
π Thanks for submitting a pull request! π
Summary
Fixes https://github.com/netlify/cli/issues/6106, https://linear.app/netlify/issue/COM-351/esm-dependencies-in-v2-functions-in-pnpm-repo-cause-crash-in-dev.
For
includedFiles
, we're recreating symlinks, sometimes in nested paths. Sometimes this breaks because the target directory doesn't exist. This PR fixes that by ensuring that a symlinks containing directory is created before the symlink itself is created.For us to review and ship your PR efficiently, please perform the following steps:
A picture of a cute animal (not mandatory, but encouraged)