netobserv / network-observability-operator

An OpenShift / Kubernetes operator for network observability
Apache License 2.0
160 stars 25 forks source link

update golangci-lint #861

Closed jotak closed 2 weeks ago

jotak commented 2 weeks ago

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/network-observability-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.70%. Comparing base (44eeb60) to head (dcbcc22). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
controllers/ebpf/agent_controller.go 42.85% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #861 +/- ## ========================================== - Coverage 64.79% 64.70% -0.10% ========================================== Files 75 75 Lines 10653 10653 ========================================== - Hits 6903 6893 -10 - Misses 3312 3326 +14 + Partials 438 434 -4 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `64.70% <55.55%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [pkg/narrowcache/client.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/861?src=pr&el=tree&filepath=pkg%2Fnarrowcache%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL25hcnJvd2NhY2hlL2NsaWVudC5nbw==) | `83.93% <100.00%> (ø)` | | | [pkg/watchers/watcher.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/861?src=pr&el=tree&filepath=pkg%2Fwatchers%2Fwatcher.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL3dhdGNoZXJzL3dhdGNoZXIuZ28=) | `68.75% <100.00%> (ø)` | | | [controllers/ebpf/agent\_controller.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/861?src=pr&el=tree&filepath=controllers%2Febpf%2Fagent_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvZWJwZi9hZ2VudF9jb250cm9sbGVyLmdv) | `51.19% <42.85%> (+0.36%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv)