search

netresearch / module-shipping-ui

The Netresearch UI package provides the presentation layer within the Magento 2 application for all custom functionality of the Netresearch Shipping Core module.
Open Software License 3.0
0 stars 1 forks source link

Netresearch_ShippingUi breaks Stripe 3D-Secure #8

Closed tobiasolge closed 1 year ago

tobiasolge commented 1 year ago

When Netresearch_ShippingUi is enabled, 3D-Secure via StripeIntegration_Payments is not working anymore. When module Netresearch_ShippingUi is disabled, 3D-Secure is working.

ngolatka commented 1 year ago

@tobiasolge Please provide feedback about the open support ticket which you created at Stripe.

ngolatka commented 1 year ago

internal ref: DHLSUP-1064713

tobiasolge commented 1 year ago

Stripe analyzed the problem this module creates!

What this module does, is that it takes over the order placement process and handles all types of checkout errors as a shipping option validation issue. This is generally bad design for a module, as it would also intercept card declines and every other order placement error, and replace the error message with a shipping options validation error.

It would be best for this module to perform this validation at the shipping page, and not at the payment page. Magento will by default try to save the selected shipping options before it reaches the payment page, and that should be the place to add this validation.

I'd recommend reaching out to Netresearch to explain the issue, they will be in a better position to provide a solution for this.

ngolatka commented 1 year ago

Thanks @tobiasolge !

@mam08ixo , could you provide some insights here?

mam08ixo commented 1 year ago

@tobiasolge: Do you have a public Magento instance available with Stripe test integration active and the DHL Shipping module enabled? Without being able to reproduce the issue, including a description of what happens vs. what is supposed to happen, it is hard to tell what exactly is causing the incompatibility and how to solve it.

The DHL module does indeed intercept the order placement process, but does not "take over". The original process still gets executed. As noted before, we need to see this in action to assess further.

Thank you

tobiasolge commented 1 year ago

I I provided infos via ticket.

ngolatka commented 1 year ago

:heavy_check_mark: Info received, we'll check it.

mam08ixo commented 1 year ago

Thank you @tobiasolge, we identified the problem and are working on a solution.

tobiasolge commented 1 year ago

top, thanks a lot

mam08ixo commented 1 year ago

Hi @tobiasolge, thank you for reporting the issue. Execute composer update --with-dependencies dhl/shipping-m2 to install version 2.4.3 of the module with updated place-order mixin.

Please let us know if the fix works for you.

tobiasolge commented 1 year ago

Hi, looks good in staging. I will try in production later on. Thanks!

tobiasolge commented 1 year ago

Hi,

the update broke our subscription module. there is the following error, when the module tries to generate the order: Rolled back transaction has not been completed correctly.

mam08ixo commented 1 year ago

Hi @tobiasolge, if the original problem has been solved, then please close the issue.

If you experience other problems, then please provide detailed steps how to reproduce – and how the DHL module is involved in causing it – via a new issue or the support channel. The given error message is not something we can work with.

Thank you