search

netresearch / t3x-rte_ckeditor_image

Image support in CKEditor for the TYPO3 ecosystem
GNU Affero General Public License v3.0
56 stars 65 forks source link

Make extension PHPStan level 8 error-free #154

Closed Physikbuddha closed 2 years ago

Physikbuddha commented 2 years ago

This pull request fixed invalid PHP/PHPDoc syntax, adds missing functionality which has been deprecated and already removed from TYPO3 core, and prevents some undetected bugs.

It is based on PR #153, since the errors fixed in there would also have been reported by PHPStan.

All error levels have been fixed in individual commits. There are still 19 more errors on level 9, but fixing them is mostly adding them to the exclusion list, since TYPO3 core type annotations are not yet as perfect as they could be.

Physikbuddha commented 2 years ago

This PR is fundamental for further improvements on the code base, i.e. adding actual PHP type annotations, fixing deprecations etc.

Next thing I would do is probably adding PHP-Codesniffer fixes and make the extension PSR-12 compatible, and removing usage of deprecated core functionality.