search

netresearch / t3x-rte_ckeditor_image

Image support in CKEditor for the TYPO3 ecosystem
GNU Affero General Public License v3.0
56 stars 65 forks source link

Revert the change "fix package name for cms_rte_ckeditor in ext_emconf.php" #280

Closed magicsunday closed 4 months ago

magicsunday commented 7 months ago

The extension name is "rte_ckeditor" not "cms_rte_ckeditor" => https://github.com/TYPO3-CMS/rte_ckeditor/blob/main/composer.json

Fixes commit: #271 5cff197

CybotTM commented 7 months ago

@magicsunday can you please describe what problem is solved by this commit?

Did you check the pipeline? It is broken now with this commit.

DavidBruchmann commented 7 months ago

In the failing tests / github "jobs" for v13 is still typo3/cms-recordlist mentioned, that was already removed in v12.

CybotTM commented 7 months ago

@DavidBruchmann, thanks, created a new issues for this.

Gitsko commented 6 months ago

@CybotTM , I am a little confused can we close this MR ?

CybotTM commented 6 months ago

@Gitsko

@CybotTM , I am a little confused can we close this MR ?

I don't know, this MR does not describe what real world problem it fixes and it breaks the build. The MR should be declined or the fixed problem should be documented and the build should be fixed before accepting this MR.

Gitsko commented 6 months ago

I agree, I would close the PR. @magicsunday you may be able to get a new MR if a problem occurs again.

dittebrandt commented 5 months ago

The extension name is "rte_ckeditor" not "cms_rte_ckeditor" => https://github.com/TYPO3-CMS/rte_ckeditor/blob/main/composer.json

Please revert commit 5cff197

This change makes it impossible to activate the extension in TYPO3 v12 (non-Composer mode).