React to PDO::commit -> false with error

nette / database

💾 A database layer with a familiar PDO-like API but much more powerful. Building queries, advanced joins, drivers for MySQL, PostgreSQL, SQLite, MS SQL Server and Oracle.

https://doc.nette.org/database

Other

512 stars 108 forks source link

React to PDO::commit -> false with error #239

Closed kratkyzobak closed 5 years ago

kratkyzobak commented 5 years ago

bug fix
BC break? no

PDO::commit can return false. In this cases transactions stays open, which is not excepted by app developers. Database layer should convert false to exception too.

dg commented 5 years ago

It should throw exception https://github.com/nette/database/blob/99b20b0ebb1e365c0b572687a088791a81047c64/src/Database/Connection.php#L68