networkservicemesh / govpp

Apache License 2.0
0 stars 5 forks source link

New govpp tagging. #28

Closed VitalyGushin closed 8 months ago

VitalyGushin commented 8 months ago

https://github.com/networkservicemesh/govpp/issues/18

glazychev-art commented 8 months ago

I'm not sure that we need to use a separate Release workflow file. Because govpp is not a typical cmd-* repository. It has a special way of building. Main differences:

I would suggest modifying ci.yaml and update-dependent-repositories.yaml to make a release.

glazychev-art commented 8 months ago

I still think we need changes in update-dependent-repositories.yaml For example: https://github.com/networkservicemesh/govpp/blob/3c0a753ca3bfcbe4f70e48ec7f4f3e1769602d91/.github/workflows/update-dependent-repositories.yaml#L71 => go get -u github.com/${{ github.repository }}@${{ inputs.docker_tag }}

or cosmetic https://github.com/networkservicemesh/govpp/blob/3c0a753ca3bfcbe4f70e48ec7f4f3e1769602d91/.github/workflows/update-dependent-repositories.yaml#L45 => ...from ${{ github.repository }}@${{ inputs.docker_tag }} What do you think?

VitalyGushin commented 8 months ago

@glazychev-art I think the behaviour won't change essentially, but it might be more informative. Fixed.