train-travatar.pl should return non-zero when sort runs out of disk

neubig / travatar

This is a repository for the Travatar forest-to-string translation decoder

GNU Lesser General Public License v3.0

28 stars 11 forks source link

train-travatar.pl should return non-zero when sort runs out of disk #34

Open kpu opened 9 years ago

kpu commented 9 years ago

I had a training run where sort ran out of disk space in step 4, printing "No space left on device". Presumably sort returned non-zero. Nonetheless, train-travatar.pl produced an ini file and returned 0. Instead, I'd prefer it fail with non-zero exit code so automation can catch it.

kpu commented 9 years ago

Looks like a missing set -e -o pipefail

neubig commented 9 years ago

Thanks for the report! I'll try to fix this soon.