search

neubig / travatar

This is a repository for the Travatar forest-to-string translation decoder
GNU Lesser General Public License v3.0
28 stars 11 forks source link

Hiero Rule Extraction #4

Closed philip30 closed 10 years ago

philip30 commented 10 years ago

In this branch, Hiero-Rule Extraction is implemented. The executed binary file can be located in src/bin/hiero-extractor.

-Philip-

neubig commented 10 years ago

Hi Philip,

Thanks for the really nice commit! Could you resolve the above comments and post an updated version? I will merge it then.

philip30 commented 10 years ago

Hi Neubig-sensei,

I have made several new commits, you can take a look at the changes I posted.

neubig commented 10 years ago

Hi Philip,

Thanks again! I checked on my environment and it seems to work, although I noticed a few small problems. Could you please fix these and I will merge it this time!

Graham

philip30 commented 10 years ago

Hi Graham-sensei, I have pushed the unit test for Hiero and fixed some bugs on output format. Please take a look on upto commit 704fdbd.

Philip

neubig commented 10 years ago

Thanks for the good work Philip! I've merged it into the main branch.