neurobagel / documentation

The neurobagel documentation
http://neurobagel.org/
MIT License
10 stars 6 forks source link

[FIX] Update environment variable name and link to query tool README #183

Closed alyssadai closed 7 months ago

alyssadai commented 7 months ago

Changes proposed in this pull request:

Checklist

Please leave checkboxes empty for PR reviewers

netlify[bot] commented 7 months ago

Deploy Preview for neurobagel-documentation ready!

Name Link
Latest commit d214176f9d2851a3f96a45bf4144b430c7167bca
Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/661018ad023cb10008ea1a4b
Deploy Preview https://deploy-preview-183--neurobagel-documentation.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alyssadai commented 7 months ago

Hey @rmanaem, thanks for catching that!

I think since the deployment recipes and docs have been already modified anyways related to this variable, I would say we can go ahead and change the port to the one used by the container to the Vite default for now. This way, at least our current instructions will work in the interim before we switch to the single-Compose recipe, and we can decide when we refine that new single-Compose file whether we want to keep this port or not.

Will request your review on a PR for this port change in the recipes repo !